orchidsoftware / orchidsoftware/platform
Secondary color does not work reliably everywhere
@tabuna is already working on this.
Since Oct 8, 2024.
- Dominant language
- PHP
- Stars
- 4.8k
- Forks
- 663
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 7
Description
Describe the bug
In Orchid 14.36.0, when a button or a link is configured to have secondary color with ->type(Color::SECONDARY), this does not work everywhere.
For example, it does work within a row layout (like in the example that ships with Orchid), but not within a table row or the command bar.
I see that in sass/core/buttons.scss there is a definition for .btn-primary which seems to override everything and make the primary color buttons work across all UI elements. Next to it, there are the same definition for . btn-success, .btn-info, and so on, but the definition for .btn-secondary is missing there.
To Reproduce
Steps to reproduce the behavior:
- Install vanilla Orchid app.
- Put a button into e.g. the command bar or a table row and give it type
Color::SECONDARY. - See that it does not look grey but is still white.
Expected behavior
Secondary color works everywhere reliably.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.