orchidsoftware / orchidsoftware/platform
Overwriting title to null displays value 1
Open
@tabuna is already working on this.
Since Jul 24, 2024.
Errors
Pending
- Dominant language
- PHP
- Stars
- 4.8k
- Forks
- 662
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 7
Description
Overwriting title to null displays value 1
Describe the bug
When the value of ->title() is overwritten to null in the form, the value 1 is displayed on the page because it passes the isset() check, and the value of $field->get('title') equals true.
To Reproduce
$field = Input::make()->title('Test')->title(null);
dd($field->get('title') === true);
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.