orchidsoftware / orchidsoftware/platform
Multiple relation filter with same column name
@tabuna is already working on this.
Since Jan 13, 2024.
- Dominant language
- PHP
- Stars
- 4.8k
- Forks
- 662
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 7
Description
Describe the bug
After filter apply url have a look like https://domain/admin/method?filter[some_id]=1&filter[some_id]= (Null value in query string leads empty response) instead of https://domain/admin/method?filter[some_id]=1
To Reproduce
Steps to reproduce the behavior:
- Create columns
public function columns(): array
{
return [
...
TD::make(some_id', 'name')->filter(Relation::make()->fromModel(Method::class, 'column1'),
TD::make('some_id', 'address')->filter(Relation::make()->fromModel(Method::class, 'column2'),
...
];
}
- Apply filters
Expected behavior
Get clean url like https://domain/admin/method?filter[some_id]=1
Server (please complete the following information):
- Platfrom Version: ^14.0
- Laravel Version: 10.39.0
- PHP Version: 8.2.4
Additional context
Need modify this function to also filter an array and get first not null value.
https://github.com/orchidsoftware/platform/blob/e0c7d9e9fc2318f1257125ebf09a6c51b1f05300/resources/js/controllers/filter_controller.js#L83
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.