orchidsoftware / orchidsoftware/platform

Multiple relation filter with same column name

Open
#2,791 0 comments 0 reactions 1 assignee View on GitHub

@tabuna is already working on this.

Since Jan 13, 2024.

Errors
Dominant language
PHP
Stars
4.8k
Forks
662
Avg merge
1d 9h
Merged PRs (30d)
7

Description

Describe the bug
After filter apply url have a look like https://domain/admin/method?filter[some_id]=1&filter[some_id]= (Null value in query string leads empty response) instead of https://domain/admin/method?filter[some_id]=1

To Reproduce
Steps to reproduce the behavior:

  1. Create columns
  public function columns(): array
    {
 return [
...
  TD::make(some_id', 'name')->filter(Relation::make()->fromModel(Method::class, 'column1'),
  TD::make('some_id', 'address')->filter(Relation::make()->fromModel(Method::class, 'column2'),
...
       ];
    }
  1. Apply filters

Expected behavior
Get clean url like https://domain/admin/method?filter[some_id]=1

Server (please complete the following information):

  • Platfrom Version: ^14.0
  • Laravel Version: 10.39.0
  • PHP Version: 8.2.4

Additional context
Need modify this function to also filter an array and get first not null value.
https://github.com/orchidsoftware/platform/blob/e0c7d9e9fc2318f1257125ebf09a6c51b1f05300/resources/js/controllers/filter_controller.js#L83

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.