orchidsoftware / orchidsoftware/platform

Relation field bug

Open
#2,693 0 comments 0 reactions 1 assignee View on GitHub

@tabuna is already working on this.

Since Aug 9, 2023.

Errors
Dominant language
PHP
Stars
4.8k
Forks
662
Avg merge
1d 9h
Merged PRs (30d)
7

Description

Hello!

Maybe I'm wrong, but in relation_controller.js in the connect method, the maximumSelectionLength attribute should be passed not like

maxItems: select.getAttribute('maximumSelectionLength') || select.hasAttribute('multiple') ? null : 1,

but like

maxItems: select.getAttribute('maximumSelectionLength') || select.hasAttribute('multiple') ? select.getAttribute('maximumSelectionLength') : 1,

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.