orchidsoftware / orchidsoftware/platform
Filtering string column (Input) with comma in value throws and error
Open
@tabuna is already working on this.
Since Jan 10, 2023.
Errors
- Dominant language
- PHP
- Stars
- 4.8k
- Forks
- 662
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 7
Description
Describe the bug
Add table with TD column and Input::make() filter. Then filter that column with comma in value.
HttpFilter method parseHttpValue would then split that query parameter into array and whole rendering of column header throws an error
Expected behavior
Column is filtered by string value without any errors. Comma is part of the filter value.
Screenshots
Server (please complete the following information):
- Platfrom Version: 13.7.1
- Laravel Version: 9
- PHP Version: 8.0
- Database: MSSQL
Additional context
I guess that split by comma (,) is used for some other filters. There should be a way to exclude that if you have normal Input filter.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.