orchidsoftware / orchidsoftware/platform

Matrix with Picture filed bug

Open
#2,258 0 comments 1 reaction 1 assignee View on GitHub

@tabuna is already working on this.

Since Jun 3, 2022.

Errors
Dominant language
PHP
Stars
4.8k
Forks
662
Avg merge
1d 9h
Merged PRs (30d)
7

Description

Describe the bug
Matrix duplicates images for new fields

To Reproduce

  1. Create Matrix with Picture field.
 Matrix::make('test')
    ->columns([
       'Picture' => 'picture',
       'Text' => 'text',
   ])
   ->fields([
       'picture' => Picture::make('picture')->maxFileSize(2)->targetId(),
       'text' => Input::make()->type('text'),
   ])
  1. Add picture
  2. Save to database
  3. Refresh page
  4. Try to add new row in matrix

Expected behavior
Clear new field without image

Screenshots
Screenshot of a bug:
image

This happens because the matrix doesn't clear data-picture-url in template
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.