orchidsoftware / orchidsoftware/platform

press Enter to filter lists screens

Open
#2,117 0 comments 1 reaction 1 assignee View on GitHub

@tabuna is already working on this.

Since Feb 8, 2022.

Dominant language
PHP
Stars
4.8k
Forks
662
Avg merge
1d 9h
Merged PRs (30d)
7

Description

Is your feature request related to a problem? Please describe.
When pressing enter in filters form should be triggered, it should not in edit screens

Describe the solution you'd like
maybe we can parametrize the view in https://github.com/orchidsoftware/platform/blob/master/src/Screen/Screen.php#L145
Or pass an optional 'sendOnEnter' => $this->sendOnEnter parameter and make this public

Additional context
issue for list screens (and fix for edit screens) has been introduced with https://github.com/orchidsoftware/platform/pull/1044/commits/e88775e90ca2201a9a18cdd62dee68d1ed982f4b

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.