orchidsoftware / orchidsoftware/platform

Collapse has same id

Open
#1,332 0 comments 0 reactions 1 assignee View on GitHub

@tabuna is already working on this.

Since Nov 2, 2020.

Errors
Dominant language
PHP
Stars
4.8k
Forks
662
Avg merge
1d 9h
Merged PRs (30d)
7

Description

Edit screen:

'Collapse example' => [
        Layout::collapse([
            Input::make('text1')->type('text')->title('Text 1')
        ])->label('Collapse 1'),
        Layout::collapse([
            Input::make('text2')->type('text')->title('Text 2')
        ])->label('Collapse 2')
]

Html result:

<div role="tabpanel" class="tab-pane active" id="tab-collapse-example">
    <div class="pt-0" data-async="">
        <p class="pl-4">
            <a data-toggle="collapse" href="#collapse-b447527abf4247acf5dd7461f27a8a40f0c89ad7" role="button" aria-expanded="false" aria-controls="collapse-b447527abf4247acf5dd7461f27a8a40f0c89ad7">
             Collapse 1
             </a>
         </p>
         <div class="collapse bg-white rounded shadow-sm mb-3 p-4" id="collapse-b447527abf4247acf5dd7461f27a8a40f0c89ad7">
            <div class="form-group">
                <label for="field-text1-21e586239ae01c04b7e9bc15ccea734cf9798d79" class="form-label">Text 1
                </label>
                <div data-controller="fields--input" data-fields--input-mask="">
                    <input class="form-control" name="text1" type="text" title="Text 1" id="field-text1-21e586239ae01c04b7e9bc15ccea734cf9798d79">
                </div>
            </div>
        </div>
    </div>
    <div class="pt-0" data-async="">
        <p class="pl-4">
            <a data-toggle="collapse" href="#collapse-b447527abf4247acf5dd7461f27a8a40f0c89ad7" role="button" aria-expanded="false" aria-controls="collapse-b447527abf4247acf5dd7461f27a8a40f0c89ad7">
             Collapse 2
             </a>
         </p>
         <div class="collapse bg-white rounded shadow-sm mb-3 p-4" id="collapse-b447527abf4247acf5dd7461f27a8a40f0c89ad7">
            <div class="form-group">
                <label for="field-text2-ccb2ab9e3230957242e5a929faa1e81db7d35187" class="form-label">Text 2
                </label>
                <div data-controller="fields--input" data-fields--input-mask="">
                    <input class="form-control" name="text2" type="text" title="Text 2" id="field-text2-ccb2ab9e3230957242e5a929faa1e81db7d35187">
                </div>
            </div>
        </div>
    </div>
</div>

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.