orchidsoftware / orchidsoftware/platform

URL not updated in browser after clicking a Link

Open
#1,049 4 comments 0 reactions 1 assignee View on GitHub

@tabuna is already working on this.

Since Feb 5, 2020.

Docs
Dominant language
PHP
Stars
4.8k
Forks
662
Avg merge
1d 9h
Merged PRs (30d)
7

Description

Describe the bug
I have a Link which heads to a Controller independent of the dashboard functionality which return redirect()->back() - the route of the link is visited and changes in the browser, however the URL is not then updated after the redirect back.

// Link
Link::make('Refresh Access Token')
   ->icon('icon-refresh')
   ->route('bank-connections.refresh-access-token', $this->request->route('bank_connection')),

To Reproduce
Steps to reproduce the behavior:

  1. Create a Link on an edit page to a Controller
  2. Perform some action in the Controller (add an Alert or Toast to see feedback in the dashboard
  3. Assert the URL in the browser changes to the Link route
  4. Assert the URL does not change back to the original

Expected behavior
When a Controller returns redirect()->back() or to any route, the URL in the browser should be updated

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Mac Mojave
  • Browser: Chrome
  • Version: 79.0.3

Server (please complete the following information):

  • Laravel Version: 6.2
  • PHP Version: 7.3.12
  • Database: MySQL
  • Database Version: 8

Additional context
There are no errors reported in the console. I also attempted to return the User back() by returning the route return redirect()->route($routeName, $routeParams);, I also redirected the User to an entirely different page on the dashboard, and the URL did not update

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.