orbiternassp / orbiternassp/NASSP
h_Pipe class does not support diffusion
Open
@indy91 is already working on this.
Since May 24, 2022.
systems
- Dominant language
- C++
- Stars
- 213
- Forks
- 74
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 6
Description
diffusion rate between two pipe-connected volumes should be proportional to:
someGlobalConstant * (in_t + out_t )/2 *pipe_size * exp(-abs(in_p - out_p))
this would be in an
if(two_ways)){
//...
}
block at the end of void h_Pipe::refresh(double dt)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.