oracle / oracle/oci-python-sdk

[NetworkLoadBalancer] Definitions are missing in the SDK

Open
#852 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

SDK
Dominant language
Python
Stars
474
Forks
321
Avg merge
23m
Merged PRs (30d)
4

Description

I work with different resource types and rely on proper typing in the SDK.
NetworkLoadBalancers define a health checker and this health checker defines DNS Details.
The parameter rcodes is defined like this:

        :param rcodes:
            The value to assign to the rcodes property of this DnsHealthCheckerDetails.
        :type rcodes: list[oci.network_load_balancer.models.DnsHealthCheckRCodes]

but the related type oci.network_load_balancer.models.DnsHealthCheckRCodes does not exist.

The property let me guess that this is a string:

    @property
    def rcodes(self):
        """
        Gets the rcodes of this DnsHealthCheckerDetails.
        An array that represents accepetable RCODE values for DNS query response.
        Example: [\"NOERROR\", \"NXDOMAIN\"]

Looking at the go definition, this is actually an enumeration.
Ideally this would be reflected correctly in the python SDK as well.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/oci/network_load_balancer/models/dns_health_checker_details.py and inspect the rcodes property and its type reference. Compare it with the Go definition mentioned in the issue and existing SDK model definitions; done means the Python SDK exposes the DNS RCODE type correctly as an enumeration.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.