oracle / oracle/oci-python-sdk

Testsuite fails with urllib3 >= 2.0.0 due to vcrpy incompatibility

Open
#535 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

SDK
Dominant language
Python
Stars
474
Forks
321
Avg merge
23m
Merged PRs (30d)
4

Description

When the system's version of urlib3 is 2.0.0 or higher, the testsuite of oci-python-sdk fails due an incompatibility of vcrpy with urlib3 >= 2.0.0:

[  458s] + pytest-3.9 --ignore=_build.python39 --ignore=_build.python311 --ignore=_build.python310 -v tests/unit tests/integ -s
[  459s] ImportError while loading conftest '/home/abuild/rpmbuild/BUILD/oci-python-sdk-2.96.0/tests/conftest.py'.
[  460s] tests/conftest.py:9: in <module>
[  460s]     from tests.integ import util
[  460s] tests/integ/util.py:13: in <module>
[  460s]     from .. import test_config_container
[  460s] tests/test_config_container.py:13: in <module>
[  460s]     import vcr
[  460s] /usr/lib/python3.9/site-packages/vcr/__init__.py:2: in <module>
[  460s]     from .config import VCR
[  460s] /usr/lib/python3.9/site-packages/vcr/config.py:11: in <module>
[  460s]     from .cassette import Cassette
[  460s] /usr/lib/python3.9/site-packages/vcr/cassette.py:12: in <module>
[  460s]     from .patch import CassettePatcherBuilder
[  460s] /usr/lib/python3.9/site-packages/vcr/patch.py:41: in <module>
[  460s]     _VerifiedHTTPSConnection = cpool.VerifiedHTTPSConnection
[  460s] E   AttributeError: module 'urllib3.connectionpool' has no attribute 'VerifiedHTTPSConnection'
[  460s] error: Bad exit status from /var/tmp/rpm-tmp.x8HlyJ (%check)

[1] https://github.com/kevin1024/vcrpy/issues/688

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tests/conftest.py, tests/integ/util.py, and tests/test_config_container.py to trace the vcr import failure, then run the pytest command shown in the issue with urllib3 2.0 or newer. Done means the test suite loads and runs successfully without the VerifiedHTTPSConnection error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.