oracle / oracle/oci-python-sdk
Referenced line hard-codes 'succeed_on_not_found' and can cause an exception when trying to pass it via kwargs
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 474
- Forks
- 321
- Avg merge
- 23m
- Merged PRs (30d)
- 4
Description
Documentation for delete_image_and_wait_for_state indicates that the user should pass options to wait_unti() via a dict.
The docs for oci.wait_util() indicate the default for this option should be False.
However in the line referenced below this option is hard-coded to True; further when trying to pass this option in the aforementioned dict, a TypeError is thrown by oci.wait_until() because it's receiving two settings for this option.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/oci/core/compute_client_composite_operations.py around line 563 and compare the documented options for delete_image_and_wait_for_state with oci.wait_until. Verify how succeed_on_not_found is passed through the options dictionary. Done means callers can provide that option without oci.wait_until receiving duplicate settings or raising the reported TypeError.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, cloud
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100