oracle / oracle/oci-cloud-controller-manager

Allow a User Friendly Values for Load Balancer Display Names

Open
#357 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature
Dominant language
Go
Stars
158
Forks
108
PR merge metrics
No merged PRs in 30d

Description

Is this a BUG REPORT or FEATURE REQUEST?

FEATURE REQUEST

I'm not entirely sure if this repo is related to OKE service in OCI but the request is still somewhat relevant.

Load Balancer services create load balancers with display name equal to the service UID instead of the service name. For a user that uses the OCI console for majority of the day, it becomes hard to manage and know what each load balancer is.

My request is to either:

  • Make the load balancer take the service name in the YAML configuration file instead of the UID.
  • Or Add annotation to allow users to configure load balancer display name while keeping the default behavior as is.

Versions

CCM Version:

Environment:

  • Kubernetes version (use kubectl version):
    Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.10", GitCommit:"a84e568eeb56c4e3966314fc2d58374febd12ed7", GitTreeState:"clean", BuildDate:"2021-03-09T14:35:22Z", GoVersion:"go1.13.15 BoringCrypto", Compiler:"gc", Platform:"linux/amd64"}

  • OS (e.g. from /etc/os-release):
    Oracle Linux Server 7.9

  • Kernel (e.g. uname -a):
    5.4.17-2036.100.6.1.el7uek.x86_64

  • Others:

What happened?

What you expected to happen?

How to reproduce it (as minimally and precisely as possible)?

Just deploy any load balancer service.

Anything else we need to know?

I traced the code a bit and I think this relates somehow to the following lines:

https://github.com/oracle/oci-cloud-controller-manager/blob/a0633ddd6dceac2945211d783d0931e2879eee87/pkg/cloudprovider/providers/oci/load_balancer_spec.go#L147

and

https://github.com/oracle/oci-cloud-controller-manager/blob/a0633ddd6dceac2945211d783d0931e2879eee87/pkg/cloudprovider/providers/oci/load_balancer_util.go#L604

I am not really into GO but I'm willing to give it a shot if no one is taking it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the referenced sections of pkg/cloudprovider/providers/oci/load_balancer_spec.go around line 147 and load_balancer_util.go around line 604, then trace how the load balancer display name is built. Compare the service-name and annotation options described in the issue and identify the relevant configuration path. Done means a deployed load balancer has a user-friendly configured display name while the existing default remains supported.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
backend, cloud
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.