oracle / oracle/oci-cloud-controller-manager

Change the default value of oci-load-balancer-security-list-management-mode to "None"

Open
#346 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
158
Forks
108
PR merge metrics
No merged PRs in 30d

Description

FEATURE REQUEST

What happened?

This property let CCM to manage the security lists for the OCI LB.

oci-load-balancer-security-list-management-mode

Its default value is set to All as stated in the load balancer annotations. Which meaning, CCM will add the security list for the LB, unless the user specify the annotation and set the value to something else.

Screen Shot 2021-03-19 at 9 14 38 AM The above screenshot is the security list that was added to the public subnet in my VCN.

I think it would be better to let the users to decide whether letting CCM to manage the security list, by setting the default value to 'None'.

What you expected to happen?

Change the default value of oci-load-balancer-security-list-management-mode to None.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with docs/load-balancer-annotations.md and search the repository for oci-load-balancer-security-list-management-mode and its current All default. Change the default to None and update the annotation documentation, then run any relevant tests or validation available for the load balancer configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cloud, networking
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.