oracle / oracle/node-oracledb

Adding RowsPerData to queryStream

Open
#633 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
2.4k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

I currently testing using the queryStream-Method to handle large data from our Database.

Because you set every row on the data-Event of the stream this is extremely slow and unusable. I wonder why this isn't a parameter. All node-Stream-Functions allow you to definie sizes of buffer.

I would suggest to add a paramter like:

queryStream(String sql, [Object bindParams], [Object options], [Number RowsPerData]);

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the queryStream entry point and trace how database rows are delivered through the stream's data events. Compare the proposed RowsPerData option with the existing queryStream signature and Node.js stream buffering behavior; the work is done when row delivery can be configured in groups for large queries and the resulting behavior is covered by appropriate tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
api, backend, database
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.