oracle / oracle/node-oracledb

Unable to process all valid rows from a stream

Open
#1,719 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
2.4k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

We have a use case where we are streaming thousands of records from a database and occasionally one record will have an error. We would love to have the option to keep streaming records even when a read fails. The current implementation always destroys the stream on any error: https://github.com/oracle/node-oracledb/blob/1d0ee743d339f27b0a3687f11618d6c7153c9f78/lib/queryStream.js#L106

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in lib/queryStream.js at the read error handling around line 106. Trace how a read failure destroys the stream and determine the behavior needed to continue processing later records. Done means valid rows can still be streamed after an individual record error without prematurely destroying the stream.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, nodejs
Domain
databases
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.