oracle / oracle/macaron

refactor SourceCodeRepo heuristic

Open
#990 0 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

checks malware analysis
Dominant language
Python
Stars
210
Forks
36
Avg merge
1d 10h
Merged PRs (30d)
2

Description

Referencing the TODO item in #983:

Currently, the SourceCodeRepo heuristic still has a dependency on the EmptyProjectLinks heuristic. This is done currently to make the merging process easier, and to avoid a heavy rework of the SUSPICIOUS_COMBOS dictionary. This dictionary is expected to soon be replaced with a more usable alternative, at which time the combinations including this heuristic may be updated.

The SourceCodeRepo heuristic must be refactored to avoid a dependency on the EmptyProjectLinks, as these two heuristics are not closely related enough for this dependency. SourceCodeRepo tracks whether a repository was found, whereas EmptyProjectLinks tracks whether any project links are available on the PyPI page of the package.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.