Disabling GIT_TERMINAL_PROMPT is insufficient in some cases
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 210
- Forks
- 36
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 2
Description
During analysis, Macaron's intent is to disable all UI prompts with regards to GitHub logins. For this purpose, the environment variable GIT_TERMINAL_PROMPT is set to False (see: Git Docs). However, in some cases that environment variable is insufficient. As also seen in the Git config docs (link), the environment variables GIT_ASKPASS and SSH_ASKPASS can also cause a prompt to appear, as can the related config value core.askPass.
As the current Macaron Docker image does not suffer from this problem, for now it is only a concern for users trying to run Macaron outside of that environment.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is identified in the issue. Start by locating where Macaron sets GIT_TERMINAL_PROMPT, then compare behavior outside the Docker image using the Git and Git config documentation for GIT_ASKPASS, SSH_ASKPASS, and core.askPass. Done means GitHub login operations no longer show UI prompts in non-Docker runs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, python
- Domain
- devops, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100