Using the maven plugin with the default VirtualFileSystem leads to pathlib.Path.exists not working
Open
@tstupka is already working on this.
Since Jun 21, 2024.
good first issue
- Dominant language
- Python
- Stars
- 1.6k
- Forks
- 155
- Avg merge
- 9h 42m
- Merged PRs (30d)
- 36
Description
This can be observed when using pyfiglet with the maven plugin. The code of pyfiglet has this
path = importlib.resources.files('pyfiglet.fonts').joinpath(fn)
if path.exists():
...
path.exists() uses a stat call, and we raise (correctly) OSError for non-existing paths. But pathlib checks that the errno of that error is in a list of allowed errors, and otherwise just throws the exception upwards. The OSError raised from the VirtualFileSystem is errno 5: EIO, it should probably be errno 2: ENOENT.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.