Absent instrumentation tags in WriteLocalVariableNode and Python call nodes with one to four arguments.
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.6k
- Forks
- 155
- Avg merge
- 9h 42m
- Merged PRs (30d)
- 36
Description
The com.oracle.graal.python.nodes.frame.WriteLocalVariableNode class does not override the hasTag method which provides the corresponding instrumentation tags. Same issue with the four nested classes: PythonCallUnary, PythonCallBinary, PythonCallTernary and PythonCallQuaternary of the com.oracle.graal.python.nodes.call.PythonCallNode class.
I will be opening a pull request with proposed fixes.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading com.oracle.graal.python.nodes.frame.WriteLocalVariableNode and the four nested call-node classes in com.oracle.graal.python.nodes.call.PythonCallNode, then compare nearby hasTag implementations. Done means each named class provides the appropriate instrumentation tags and the existing instrumentation behavior remains valid.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, python
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100