optics-dev / optics-dev/Monocle
Properly match on the actual `KeywordContext` symbol
Open
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 1.7k
- Forks
- 207
- Avg merge
- 7h 59m
- Merged PRs (30d)
- 5
Description
Currently we're matching on Ident and strings; we should definitely be matching on specific symbols instead.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the matching logic that currently checks Ident and strings, then trace how the actual KeywordContext symbol is represented and compared. Confirm the relevant behavior with the existing tests or reproduction, and consider the work done when matching uses the specific symbols rather than those broader forms.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100