security/tor: Advanced mode / help toggles are broken
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 1.2k
- Forks
- 863
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 10
Description
Important notices
Before you add a new report, we ask you kindly to acknowledge the following:
- I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
- I have searched the existing issues, open and closed, and I'm convinced that mine is new.
- The title contains the plugin to which this issue belongs
Describe the bug
The "advanced mode" and "full help" toggles within the Tor plugin do not display the advanced configuration items or help text. There is no response whatsoever when activating these toggles.
This appears to be related to recent changes within opnsense-ui.js (see core@4b4f0e2 / core@6dd4cde and core@a462959), which parses forms whose id attribute begins with the string value "frm". The forms for the tor plugin do not begin with this value, and therefore the JS action to display advanced configuration or help text no longer applies to the plugin's forms.
To Reproduce
Steps to reproduce the behavior:
- Install the Tor plugin.
- Go to the Configuration menu.
- Go to either the General or the Relaying tab.
- Click the toggle for "advanced mode" or "full help."
- See that nothing happens.
Expected behavior
Toggling "advanced mode" should display additional configuration items. Toggling "full text" should display help text for all items (where available).
Additional context
I used my browser's dev tools to edit the form id attribute on the tor plugin's General tab. When edited to "frm_general", the toggle for advanced mode worked as expected, because the JS action in opnsense-ui.js applied correctly.
Environment
OPNsense 26.7.4_1-amd64
Virtualized in Proxmox VE / QEMU
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with opnsense-ui.js and the Tor plugin forms used by the General and Relaying tabs. Reproduce the advanced mode and full help toggles, then inspect their form ids against the frm prefix behavior described in the issue. Done means both toggles display their expected configuration items and help text in the Tor plugin.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, php
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100