opnsense / opnsense/plugins

os-bind: Add include directory for custom options (named.conf)

Open
#5,449 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
1.2k
Forks
863
Avg merge
2d 6h
Merged PRs (30d)
10

Description

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

Is your feature request related to a problem? Please describe.
I am trying to configure DoT for connection to forwarders. Since this requires more than just an IP address the current form does not seem to suit. I think adding this functionality to the form may not be the best and so ideally would like to have a separate include directive for custom options.

Describe the solution you'd like
Can we add an include line in the options stanza like #4773, but to allow custom options.
A new directory would also be needed, maybe named-options.conf.d

Describe alternatives you've considered
I have currently edited the named.conf to add this include directive manually, but I assume this will get wiped out with the next upgrade. We could also add this option to the input form, however I think this is less work, is more flexible and also solves other issues like #1715.

I can put together a pull request for this if thats OK?

Thanks again for an awesome firewall!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the os-bind code that generates named.conf and compare its include handling with the approach discussed in issue #4773. Add support for an options include directory such as named-options.conf.d, then verify that custom option files are included in generated configuration and survive upgrades.

Written by the indexing model from the issue text.

Assessment

Domain
networking
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
64/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.