opnsense / opnsense/plugins

siproxd issue while adding ip addresses

Open
#5,413 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
1.2k
Forks
863
Avg merge
2d 6h
Merged PRs (30d)
10

Description

Describe the bug
When adding multiple ip addresses in the fields "Hosts to allow registration", "Hosts to allow SIP" and / or "Hosts to allow SIP" it will only accept 1 ip address multiple addresses are not accepted in the gui, so:
192.168.9.125/32 is accepted and 192.168.9.125/32,192.168.9.130/32 is not accepted.
The help says: Here you specify the devices allowed to do SIP connections to siproxd (internal and external). Format is CSV without spaces and CIDR, like 192.168.0.0/24,10.0.0.0/8.
So according to the help and the siproxd documentation it should be possible.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Services\Siproxd'
  2. Click on 'General'
  3. Scroll down to 'Hosts to allow registration' or 'Hosts to allow SIP' or 'Hosts to allow SIP'
  4. See error

Expected behavior
Expect to input multiple IP-addresses/Networks according CSV format without spaces and CIDR, like 192.168.0.0/24,10.0.0.0/8..

Screenshots
Image
Image

Relevant log files
N.A.

Additional context
Add any other context about the problem here.

Environment
Software version used and hardware type if relevant.
OPNsense 26.1.6-amd64
FreeBSD 14.3-RELEASE-p10
OpenSSL 3.0.20
Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz (4 cores, 4 threads)
Network Intel®
os-siproxd 1.3_3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in Services\Siproxd on the General page, focusing on validation for the Hosts to allow registration and Hosts to allow SIP fields. Reproduce the error with comma-separated CIDR addresses such as 192.168.9.125/32,192.168.9.130/32; done means multiple addresses are accepted and saved as described by the help text.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.