siproxd issue while adding ip addresses
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 1.2k
- Forks
- 863
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 10
Description
When adding multiple ip addresses in the fields "Hosts to allow registration", "Hosts to allow SIP" and / or "Hosts to allow SIP" it will only accept 1 ip address multiple addresses are not accepted in the gui, so:
192.168.9.125/32 is accepted and 192.168.9.125/32,192.168.9.130/32 is not accepted.
The help says: Here you specify the devices allowed to do SIP connections to siproxd (internal and external). Format is CSV without spaces and CIDR, like 192.168.0.0/24,10.0.0.0/8.
So according to the help and the siproxd documentation it should be possible.
Please resolve this issue.
Thanks,
Ed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the siproxd plugin's GUI handling for the fields "Hosts to allow registration" and "Hosts to allow SIP", then reproduce the validation with one CIDR and with a comma-separated CIDR list. Done means multiple comma-separated addresses are accepted consistently with the documented CSV format, without spaces.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 62/100