openzim / openzim/python-scraperlib
HTML rewriting: also rewrite `poster` attribute
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 31
- Forks
- 27
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 2
Description
https://github.com/openzim/python-scraperlib/pull/338 identified that when rewriting HTML, we do not rewrite of the poster attribute.
This should be added because it is clearly just a detail we have overlooked IMHO (and https://github.com/openzim/python-scraperlib/pull/338 changes adapted accordingly to also handle the poster attribute).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing pull request #338 and the repository's HTML rewriting implementation to find where HTML attributes are rewritten. Add handling for the poster attribute alongside the existing rewritten attributes, then verify that the behavior matches the adaptation described in pull request #338.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 72/100