openzim / openzim/python-libzim

Wrong exception is raised at keyboard interrupt (and application never finishes)

Open
#201 0 comments 0 reactions 1 assignee View on GitHub

@rgaudin is already working on this.

Since Sep 12, 2024.

bug question
Dominant language
Python
Stars
108
Forks
29
Avg merge
9d 1h
Merged PRs (30d)
1

Description

See https://github.com/openzim/devdocs/issues/14

The fact that the application never finishes might lie in how the scraper handles the creator object, but I don't get why when the user issues a keyboard interrupt we end-up with a weird AttributeError: 'StaticItem' object has no attribute 'get_mimetype'

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.