Fix dyn compilation warning on Windows
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 256
- Forks
- 75
- Avg merge
- 8d 51m
- Merged PRs (30d)
- 4
Description
When building dll on Windows we have to specify what is exported in dll.
We already export of public symbol with __declspec(dllexport).
But we have a lot of warning as our structure/class are including std symbols and we are not exporting them.
See : kiwix/kiwix-build@d2d1f68 (#703)
One solution would be to export ALL symbols in the dll but this should probably made with a generated .def file.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the Windows DLL build and the linked kiwix-build commit d2d1f68 (#703), then inspect how exported symbols are currently declared. Determine whether a generated .def file or another export approach addresses the warnings. Done means the Windows build no longer reports these export warnings while the DLL's public symbols remain available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100