openzim / openzim/libzim

Add a way to cancel the ZIM file creation

Open
#347 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
256
Forks
75
Avg merge
8d 51m
Merged PRs (30d)
4

Description

There is no way to cancel the zim file creation.
Either we finalize it or we don't. But do not finalize the creator may leads to some crash due to some thread cleaning not being done.

We have to either add a method cancel or properly handle the final cleaning (or both).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by tracing the ZIM file creation and finalize lifecycle, then inspect how worker-thread cleanup behaves when finalization is skipped. Done means creation can be cancelled or safely cleaned up without a crash, with the relevant behavior covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.