openzim / openzim/javascript-libzim

Try to compile to a lower target to support older browsers

Open
#17 7 comments 0 reactions 1 assignee View on GitHub

@Jaifroid is already working on this.

Since Nov 27, 2022.

  • #18 by @Jaifroid — closed without merging
bug build help wanted
Dominant language
JavaScript
Stars
5
Forks
2
PR merge metrics
No merged PRs in 30d

Description

When we compiled XZ and ZSTD to WASM, we were also able to compile to ASM (the older, JavaScript-only version, which is quite fast and well optimized across most browsers). But even if we can only compile to WASM, the current build isn't working with some browsers that normally support WASM pretty well: notably UWP webview (and hence Edge Legacy), and Chrome for Android.

One possible solution might be to compile without pthreads: see https://github.com/emscripten-core/emscripten/issues/13152#issuecomment-753226011.

But in principle, I don't see why we couldn't also try to produce ASM versions. It's normally just a change in the emcc commandline, but possibly can also be done with emmconfigure.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.