openzim / openzim/gutenberg

Add space before the ellipsis to avoid four consecutive dots

Open
#562 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
173
Forks
59
Avg merge
14h 17m
Merged PRs (30d)
34

Description

When the last thing before automatically added ellispsis is a dot, we end-up with four consecutives dots.

Image

While rare, it is not really visually appealing. We should find a solution to add space between the point and the ellipsis when last character shown is already a punctuation mark.

This ellipsis is fully managed by the browser, I did not really find a not hackish solution so far.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by locating the frontend text element where the browser adds the ellipsis, then reproduce the case where the final visible character is a dot or other punctuation. Done means punctuation and the automatically added ellipsis are separated so four consecutive dots are not shown.

Written by the indexing model from the issue text.

Assessment

Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.