[qt5base] Fix --qpa option handling when linuxfb plugin is deselected
Nobody has claimed this yet.
- Dominant language
- Makefile
- Stars
- 90
- Forks
- 97
- Avg merge
- 5d 19h
- Merged PRs (30d)
- 13
Description
I encountered a compilation error for qt5base on the main branch when the qt5base-plugin-platforms-linuxfb package is not selected:
ERROR: No value supplied to command line option 'qpa'.
This stems from the line in package/feed/video/qt5/qt5base/Makefile:
--qpa=$(if $(CONFIG_PACKAGE_qt5base-plugin-platforms-linuxfb),linuxfb,) \
When CONFIG_PACKAGE_qt5base-plugin-platforms-linuxfb is unset, this results in --qpa= being passed, which is an invalid argument.
The fix is to condition the entire option, so it's only included when the plugin is enabled:
$(if $(CONFIG_PACKAGE_qt5base-plugin-platforms-linuxfb),--qpa=linuxfb,) \
This ensures --qpa=linuxfb is only added when necessary.
@mirko, I'm bringing this to your attention as you're familiar with the Qt5 packages.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open package/feed/video/qt5/qt5base/Makefile and inspect the --qpa option handling. Reproduce or review the configuration with qt5base-plugin-platforms-linuxfb deselected, then verify that the invalid empty option is no longer passed and that the qt5base package builds successfully.
Written by the indexing model from the issue text.
Assessment
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100