dahdi-linux: error: 'inline' is not at beginning of declaration
Open
Nobody has claimed this yet.
- Dominant language
- Makefile
- Stars
- 133
- Forks
- 327
- PR merge metrics
- No merged PRs in 30d
Description
Info
Maintainer: @VittGam
OpenWrt daily snapshot
Problem
/builder/shared-workdir/build/sdk/build_dir/target-aarch64_cortex-a53_musl/linux-bcm27xx_bcm2710/dahdi-linux-2024.04.12~83d89b64/drivers/dahdi/wct4xxp/base.c:1175:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration]
1175 | static void inline t4_hdlc_xmit_fifo(struct t4 *wc, unsigned int span, struct t4_span *ts)
| ^~~~~~
cc1: all warnings being treated as errors
Log is available here: https://downloads.openwrt.org/snapshots/faillogs/aarch64_cortex-a53/telephony/dahdi-linux/compile.txt
Solution
Apply this patch:
https://github.com/asterisk/dahdi-linux/commit/fe19b533513a2dbc69208bb3ca5dd4948c72c7b9
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the failing drivers/dahdi/wct4xxp/base.c entry at line 1175 and review the linked dahdi-linux commit fe19b533513a2dbc69208bb3ca5dd4948c72c7b9. Use the OpenWrt compile log to reproduce the warning, then verify that the dahdi-linux package builds successfully without the old-style-declaration error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, linux
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100