openwrt / openwrt/telephony

asterisk: Need simpler conffiles definitions

Open
#808 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Makefile
Stars
133
Forks
327
PR merge metrics
No merged PRs in 30d

Description

Maintainer: @jslachta
Environment: x86_64, generic, HEAD
Description:

Looking at the conffiles definition in the Makefile, it's not clear it's correct.

Instead of enumerating the files in /etc/asterisk/ it would make more sense to just name that directory. For instance, if you make a copy of a config file as:

% cp -a extensions.conf extensions.conf.orig

before editing the file, or perhaps (periodically) a timestamped version of it like:

% cp -a extensions.conf extensions.conf.$(date +%Y%m%d)

then you'd want those files preserved across sysupgrades. I also note the lack of .ael files as being backed up.

The file /etc/init.d/asterisk isn't really modifiable and probably should be updated via sysupgrade (as options are expressed in /etc/config/asterisk instead).

Lastly, cryptographic keys (used by res_crypto) are stored in /var/lib/asterisk/keys/ and definitely should be backed up, along with /var/lib/asterisk/astdb/.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the conffiles definition in the Makefile and review how the listed /etc/asterisk/, /var/lib/asterisk/keys/, and /var/lib/asterisk/astdb/ paths are handled by sysupgrade. Check the treatment of /etc/init.d/asterisk against the issue’s description. Done means the intended configuration, backup, key, and database files are preserved while the init script is updated appropriately.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.