openwrt / openwrt/packages

[Meta] Prefered look of Makefiles

Open
#9,682 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

meta
Dominant language
Makefile
Stars
4.6k
Forks
4k
Avg merge
3d 12h
Merged PRs (30d)
134

Description

@BKPepe @val-kulkov @neheb
Hi,
I would like to start a discussion about the preferred look of Makefiles.

This is an extension of discussion from PR https://github.com/openwrt/packages/pull/9667#issuecomment-518674778

My idea is, if we could define some guidelines how should Makefile look (variable orders, tabs usage etc.) in a more explicit way. I believe that it can have advantages of in case of change review and possibly in future, this could be used as a specification for a tool which could check that automatically.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading CONTRIBUTING.md and the linked discussion in PR 9667. Review the existing Makefiles for the variable order and tab-usage conventions mentioned in the issue. Done means documenting an agreed, explicit style specification, with any checking-tool requirements clearly defined.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Documentation
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.