Pull request policies
Nobody has claimed this yet.
- Dominant language
- Makefile
- Stars
- 4.6k
- Forks
- 4k
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 134
Description
This is mainly concerns members and frequent contributors but can we agree on not to open PRs just for the sake of it?
PRs should be run-tested on at least one platform before being submitted unless maintainer of a package has clearly stated otherwise. Also, commit message should contain all changes being made.
If a change isn't specific to OpenWrt please try to upstream it first.
Given our limited resources I don't think we need more administrative work than needed.
Also while I'm at it, how should we handle new package submissions?
We have quite a few queued, could this be a good idea?
https://github.com/openwrt/packages/pull/8509#issuecomment-477390648
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading CONTRIBUTING.md and the linked pull-request discussion at openwrt/packages#8509. The issue combines proposed pull-request policies with a question about queued package submissions, and it does not define a specific documentation change or acceptance criteria; completion would require maintainers to agree on scope first.
Written by the indexing model from the issue text.
Assessment
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100