uacme-dnsapi-adapter: Missing implementation of _secure_debug*
Nobody has claimed this yet.
- Dominant language
- Makefile
- Stars
- 4.6k
- Forks
- 4k
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 134
Description
Package Name
uacme-dnsapi-adapter
Maintainer
@lucize
OpenWrt Version
25.12.5
OpenWrt Target/Subtarget
x86/64
Steps to Reproduce
The uacme-dnsapi-adapter package ships a custom shell script not present in the original uacme source code.
The dnsapi_helper.sh provides a wrapper around the ACME.sh DNS API. The present implementation lacks _secure_debug, _secure_debug2 and _secure_debug3. Therefore any use of a DNS API using _secure_debug* throws a runtime error.
Actual Behaviour
The dnsapi_helper.sh should include implementations for _secure_debug*. The original implementations check whether the --output-insecure flag is set. uacme does not have this flag. I'd therefore suggest to just ignore any _secure_debug* output.
I'd moreover suggest to consider contributing the dnsapi-adapter implementation to the uacme upstream given they welcome such an effort. This could in future prevent from such oddities.
Since I'm somehow uncertain how far the dnsapi_helper.sh is supported by the original author (given they're mentioned in the file header), I opened an adjacent issue in their repository : https://github.com/ndilieto/uacme/issues/113
Confirmation Checklist
- The package is maintained in this repository.
- I understand that issues related to the base OpenWrt repository or LuCI repository will be closed.
- I am reporting an issue for OpenWrt, not an unsupported fork.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with net/uacme/files/dnsapi_helper.sh and compare its debug helpers with the referenced acme.sh implementations. Check how uacme invokes _secure_debug, _secure_debug2, and _secure_debug3, then verify that DNS API calls no longer fail when they use them and that their output is safely ignored without an --output-insecure flag.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100