openwrt / openwrt/packages

lm-sensors: ath11k temp sensor name collision

Open
#29,342 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Makefile
Stars
4.6k
Forks
4k
Avg merge
3d 12h
Merged PRs (30d)
134

Description

Package Name

lm-sensors

Maintainer

Jo-Philipp Wich jo@mein.io

OpenWrt Version

SNAPSHOT

OpenWrt Target/Subtarget

qualcommax/ipq807x

Steps to Reproduce

Install on Linksys MX4300 (and maybe other qualcommax targets), run sensors in console.

Actual Behaviour

There are multiple ath11k temp sensor with the exact same name:

# sensors | grep ath11k
ath11k_hwmon-isa-c000000
ath11k_hwmon-isa-c000000
ath11k_hwmon-isa-c000000

This results in failures in e.g. collectd.

Relevant dmesg output:

# dmesg | grep ath11k
[   11.499498] ath11k c000000.wifi: ipq8074 hw2.0
[   11.499539] ath11k c000000.wifi: FW memory mode: 0
[   12.753501] ath11k c000000.wifi: chip_id 0x0 chip_family 0x0 board_id 0xff soc_id 0xffffffff
[   12.753557] ath11k c000000.wifi: fw_version 0x290b84a5 fw_build_timestamp 2024-09-23 11:32 fw_build_id WLAN.HK.2.9.0.1-02146-QCAHKSWPL_SILICONZ-1
[   13.512704] ath11k c000000.wifi: chip_id 0x0 chip_family 0x0 board_id 0xff soc_id 0xffffffff
[   13.512758] ath11k c000000.wifi: fw_version 0x290b84a5 fw_build_timestamp 2024-09-23 11:32 fw_build_id WLAN.HK.2.9.0.1-02146-QCAHKSWPL_SILICONZ-1
[   13.899012] ath11k c000000.wifi: htt event 48 not handled
[   19.800115] ath11k c000000.wifi phy0-ap0: entered allmulticast mode
[   19.805829] ath11k c000000.wifi phy0-ap0: entered promiscuous mode
[   20.896114] ath11k c000000.wifi phy0-ap1: entered allmulticast mode
[   20.901902] ath11k c000000.wifi phy0-ap1: entered promiscuous mode
[   20.909451] ath11k c000000.wifi phy0-ap1: left allmulticast mode
[   20.914143] ath11k c000000.wifi phy0-ap1: left promiscuous mode
[   20.937085] ath11k c000000.wifi phy0-ap1: entered allmulticast mode
[   20.942958] ath11k c000000.wifi phy0-ap1: entered promiscuous mode
[   21.621484] ath11k c000000.wifi phy1-ap0: entered allmulticast mode
[   21.627191] ath11k c000000.wifi phy1-ap0: entered promiscuous mode
[   22.048002] ath11k c000000.wifi phy1-ap1: entered allmulticast mode
[   22.053853] ath11k c000000.wifi phy1-ap1: entered promiscuous mode
[   22.936296] ath11k c000000.wifi phy2-ap0: entered allmulticast mode
[   22.942202] ath11k c000000.wifi phy2-ap0: entered promiscuous mode

Maybe need to append the PHY number to the address?

Similar to https://github.com/openwrt/packages/issues/10623 but one step further.

Confirmation Checklist

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the duplicate output with the sensors command on a qualcommax/ipq807x device, then trace the lm-sensors and ath11k hwmon registration involved in the ath11k_hwmon-isa-c000000 names. Done means each sensor has a unique name and consumers such as collectd can read all sensors without collisions.

Written by the indexing model from the issue text.

Assessment

Tech stack
linux
Domain
embedded-iot, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.