chrony: maxsources directive is only respected for pools named "pool"
Open
Nobody has claimed this yet.
bug
- Dominant language
- Makefile
- Stars
- 4.6k
- Forks
- 4k
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 134
Description
Package Name
chrony
Maintainer
@mlichvar
OpenWrt Version
25.12.2
OpenWrt Target/Subtarget
mediatek/filogic
Steps to Reproduce
- Add a pool with any name other than "pool" (including no name)
- Set a maxsources directive for the pool
- Commit the changes and restart chronyd
Actual Behaviour
No maxsources directive appears on the pool line in /var/etc/chrony.d/10-uci.conf.
The check on line 48 in chronyd.init should probably test against $sourcetype rather than $cfg?
Confirmation Checklist
- The package is maintained in this repository.
- I understand that issues related to the base OpenWrt repository or LuCI repository will be closed.
- I am reporting an issue for OpenWrt, not an unsupported fork.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect chronyd.init, especially the check on line 48, and compare it with how the pool source type is handled. Reproduce the configuration using a pool with a non-"pool" name and a maxsources directive, then restart chronyd and verify that /var/etc/chrony.d/10-uci.conf contains maxsources on the pool line.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100