openvpn: stub compression stops working with new changes
Nobody has claimed this yet.
- Dominant language
- Makefile
- Stars
- 4.6k
- Forks
- 4k
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 134
Description
Package Name
openvpn
Maintainer
@systemcrash
OpenWrt Version
SNAPSHOT
OpenWrt Target/Subtarget
aarch64/generic
Steps to Reproduce
- Try to add an openvpn client config that supports compress stub-v2
- Doesn't even accept compress option
Actual Behaviour
Previously working compression. I understand the disable of compression for security reasons, but we should have this opt-in. Also, for disabled compression builds, we should still be able to sue stub* compression methods, because they are not actually compression, but rather added frames to tell the server that you use compression. It doesn't impose any security risk and it's just nonsense to enforce the user.
See https://github.com/openwrt/packages/pull/28533#issuecomment-3994776775 for more details.
Confirmation Checklist
- The package is maintained in this repository.
- I understand that issues related to the base OpenWrt repository or LuCI repository will be closed.
- I am reporting an issue for OpenWrt, not an unsupported fork.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by reviewing the OpenVPN package handling for the compress option and the discussion in pull request #28533; determine where stub-v2 is rejected. Done means disabled-compression builds accept the stub* methods while continuing to reject actual compression methods.
Written by the indexing model from the issue text.
Assessment
- Domain
- networking, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100