openwrt / openwrt/packages

ddns: no support for comma separated multi domain value

Open
#27,928 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Makefile
Stars
4.6k
Forks
4k
Avg merge
3d 12h
Merged PRs (30d)
134

Description

Package Name

ddns

Maintainer

@feckert

OpenWrt Version

24.10.4

OpenWrt Target/Subtarget

mediatek/filogic

Steps to Reproduce

duckdns.org allows for multiple comma separated domains in the domain field to update multiple domains with a single curl call
e.g.

"https://www.duckdns.org/update?domains=d1,d2,d3&token=****&ip="

Actual Behaviour

When adding d1,d2,d3 as part of the DOMAIN field, ddns complaints about sanitization of the content, i guess due to the comma.
Would it be possible to update the script to reduce the number of calls?

Confirmation Checklist

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by locating the ddns package implementation and its DOMAIN sanitization path, then reproduce the DuckDNS request with comma-separated domains. Done means a value such as d1,d2,d3 is accepted and updates multiple domains with one request without breaking existing single-domain behavior.

Written by the indexing model from the issue text.

Assessment

Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.