atlas-sw-probe: wrong flags used in ssh-keygen, no exception handling for failed ssh-keygen invocations.

Package Name

atlas-sw-probe

Maintainer

@ansuel

OpenWrt Version

OpenWrt 24.10.4, r28959-29397011cc

OpenWrt Target/Subtarget

all

Steps to Reproduce

The script /etc/init.d/atlas create_key fails on OpenWRT since it uses dropbear ssh-keygen instead of OpenSSL.

ssh-keygen -t rsa -b 2048 should be instead ssh-keygen -t rsa -s 2048

Also, there is no exception handling for calling ssh-keygen, so when the error is thrown and the script claims it completes successfully.

root@OpenWrt:/usr/libexec/atlas-probe-scripts/data/out# ssh-keygen
Must specify a key filename
Usage: ssh-keygen -t <type> -f <filename> [-s bits]
-t type Type of key to generate. One of:
                rsa
                ed25519
-f filename    Use filename for the secret key.
               ~/.ssh/id_dropbear is recommended for client keys.
-s bits Key size in bits, should be a multiple of 8 (optional)
           Ed25519 has a fixed size of 256 bits
-y              Just print the publickey and fingerprint for the
                private key in <filename>.
-C              Specify the key comment (email).

Actual Behaviour

Kye was not created by script.

Confirmation Checklist

• The package is maintained in this repository.
• I understand that issues related to the base OpenWrt repository or LuCI repository will be closed.
• I am reporting an issue for OpenWrt, not an unsupported fork.

Start by inspecting the /etc/init.d/atlas create_key script and its ssh-keygen invocation. Verify the key-generation flags against the shown ssh-keygen usage, then check how a failed invocation is reported. Done means the key is created successfully and failures no longer claim completion.