openconnect: Server name without protocol breaks host dependency adding
Nobody has claimed this yet.
- Dominant language
- Makefile
- Stars
- 4.6k
- Forks
- 4k
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 134
Description
Package Name
openconnect
Maintainer
@nmav
OpenWrt Version
24.10.2
OpenWrt Target/Subtarget
mediatek/filogic
Steps to Reproduce
- Set "VPN Server" in LuCI to e.g. "vpn.foo.com" (no https)
Actual Behaviour
In ab8adb7d76d1ee1595311cb88a9b5cdaf34a2a5f, the line for establishing $server from $uri will only work if the value includes a protocol (e.g. https://). Without it, $server will remain empty, and no host dependency will be added.
[ -n $uri ] && server=$(echo $uri | awk -F[/:] '{print $4}')
As there is no validation for this in LuCI, and previously users always added the hostname here (without protocol), it might be helpful to make this more resilient.
Thank you for your work on this project!
Confirmation Checklist
- The package is maintained in this repository.
- I understand that issues related to the base OpenWrt repository or LuCI repository will be closed.
- I am reporting an issue for OpenWrt, not an unsupported fork.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the openconnect package code containing the shown $server assignment and reproduce the LuCI configuration with a hostname lacking a protocol. Verify that the resulting host dependency is added for vpn.foo.com, while preserving the existing behavior for protocol-prefixed values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- awk, shell
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100