openwrt / openwrt/packages

openconnect: Server name without protocol breaks host dependency adding

Open
#27,045 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Makefile
Stars
4.6k
Forks
4k
Avg merge
3d 12h
Merged PRs (30d)
134

Description

Package Name

openconnect

Maintainer

@nmav

OpenWrt Version

24.10.2

OpenWrt Target/Subtarget

mediatek/filogic

Steps to Reproduce
  1. Set "VPN Server" in LuCI to e.g. "vpn.foo.com" (no https)
Actual Behaviour

In ab8adb7d76d1ee1595311cb88a9b5cdaf34a2a5f, the line for establishing $server from $uri will only work if the value includes a protocol (e.g. https://). Without it, $server will remain empty, and no host dependency will be added.

[ -n $uri ] && server=$(echo $uri | awk -F[/:] '{print $4}')

As there is no validation for this in LuCI, and previously users always added the hostname here (without protocol), it might be helpful to make this more resilient.

Thank you for your work on this project!

Confirmation Checklist

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the openconnect package code containing the shown $server assignment and reproduce the LuCI configuration with a hostname lacking a protocol. Verify that the resulting host dependency is added for vpn.foo.com, while preserving the existing behavior for protocol-prefixed values.

Written by the indexing model from the issue text.

Assessment

Tech stack
awk, shell
Domain
networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.