frr: initscript script "source" causes errors in imagebuilder
Nobody has claimed this yet.
- Dominant language
- Makefile
- Stars
- 4.6k
- Forks
- 4k
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 134
Description
Package Name
frr
Maintainer
@lucize
OpenWrt Version
24.10.2
OpenWrt Target/Subtarget
any/all
Steps to Reproduce
Build an image using the imagebuilder that includes the frr package.
Actual Behaviour
Error messages are emitted during the image bulid:
…
Finalizing root filesystem...
/home/brian/openwrt-imagebuilder-24.10.2-ath79-generic.Linux-x86_64/build_dir/target-mips_24kc_musl/root-ath79/etc/init.d/frr: line 21: /usr/sbin/frrcommon.sh: No such file or directory
Enabling boot
Enabling boot.sav
Enabling bootcount
Enabling cron
Enabling done
Enabling dropbear
./etc/init.d/frr: line 21: /usr/sbin/frrcommon.sh: No such file or directory
Enabling frr
Enabling gpio_switch
Enabling led
Enabling log
Enabling network
…
So it seems that a package's initscript is actually executed as part of building an image given the above. It seems that initscripts need to be aware of this and act accordingly.
Confirmation Checklist
- The package is maintained in this repository.
- I understand that issues related to the base OpenWrt repository or LuCI repository will be closed.
- I am reporting an issue for OpenWrt, not an unsupported fork.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the generated etc/init.d/frr mentioned in the report and trace it back to the frr package source, focusing on line 21 and the reference to /usr/sbin/frrcommon.sh. Reproduce an imagebuilder build that includes frr and verify that finalization completes without the missing-file error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100