openwrt / openwrt/packages

collectd,luci-app-statistics: mess in configurations

Open
#26,736 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Makefile
Stars
4.6k
Forks
4k
Avg merge
3d 12h
Merged PRs (30d)
134

Description

Package Name

collectd,luci-app-statistics

Maintainer

Jo-Philipp Wich jo@mein.io, Hannu Nyman hannu.nyman@iki.fi

OpenWrt Version

24.10.1

OpenWrt Target/Subtarget

x86/64

Steps to Reproduce
  1. created manually file

cat /etc/config/collectd

config plugin 'rrdtool'
option enable '1'
option DataDir '/tmp/rrd'
option RRARows '100'
option RRASingle '1'
list RRATimespan '3600'
list RRATimespan '86400'
list RRATimespan '604800'
list RRATimespan '2678400'
list RRATimespan '31622400'

config plugin 'cpu'
option enable '1'

config plugin 'memory'
option enable '1'

config plugin 'load'
option enable '1'

config plugin 'interface'
option enable '1'
list Interface 'br-lan'

config plugin 'ipta

  1. enable bunch of plugins via luci
  2. check actual graphs on luci
Actual Behaviour

Actual result: enabled plugins on luci affects next file (BTW
https://github.com/openwrt/packages/issues/12138 not fixed):

cat /etc/collectd.conf

BaseDir "/var/run/collectd"
Include "/etc/collectd/conf.d/*.conf"
PIDFile "/var/run/collectd.pid"
PluginDir "/usr/lib/collectd"
TypesDB "/usr/share/collectd/types.db"
Interval 300
ReadThreads 2

LoadPlugin cpu

ValuesPercentage true
ReportByCpu true
ReportByState true

LoadPlugin interface

Interface "br-lan"
Interface "docker0"
Interface "tailscale0"

LoadPlugin iwinfo

Interface "phy0-ap0"

LoadPlugin load

LoadPlugin memory

LoadPlugin rrdtool

DataDir "/tmp/rrd"
RRARows 288
RRASingle true
RRATimespan 7200
RRATimespan 86400
RRATimespan 604800
RRATimespan 2678400
RRATimespan 31622400

LoadPlugin sensors

Sensor "it8613-isa-0a30/voltage-in0"
Sensor "it8613-isa-0a30/voltage-in1"
Sensor "it8613-isa-0a30/voltage-in2"
Sensor "it8613-isa-0a30/voltage-in4"
Sensor "it8613-isa-0a30/voltage-in5"
Sensor "it8613-isa-0a30/fanspeed-fan2"
Sensor "it8613-isa-0a30/fanspeed-fan3"
Sensor "it8613-isa-0a30/fanspeed-fan5"
Sensor "it8613-isa-0a30/temperature-temp1"
Sensor "it8613-isa-0a30/temperature-temp2"
Sensor "it8613-isa-0a30/temperature-temp3"
Sensor "drivetemp-scsi-1-0/temperature-temp1"

LoadPlugin thermal

while real graphs afre taken only from plugins in /etc/config/collectd

Expected result: either use /etc/config/collectd or /etc/collectd.conf but never both!

Confirmation Checklist

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the manually created /etc/config/collectd with the generated /etc/collectd.conf after enabling plugins through LuCI. Trace how luci-app-statistics settings produce the collectd configuration and determine which file is actually used for graphs. Done means one consistent configuration source is used, without conflicting settings from both files.

Written by the indexing model from the issue text.

Assessment

Domain
observability
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.