openwrt / openwrt/packages

ddns-scripts: whitespace is not properly escaped for /etc/resolv.conf

Open
#26,724 1 comment 0 reactions 1 assignee View on GitHub

@feckert is already working on this.

Since Jun 10, 2025.

bug
Dominant language
Makefile
Stars
4.6k
Forks
4k
Avg merge
3d 12h
Merged PRs (30d)
134

Description

Package Name

ddns-scripts

Maintainer

NONE

OpenWrt Version

24.10.1

OpenWrt Target/Subtarget

ramips/mt7621

Steps to Reproduce
  1. Simply add a space at the end of your nameserver definition in /etc/resolv.conf
  2. Error log /var/run/ddns/*.err will display that the ip is not valid, eg, '127.0.0.1 '

admittedly small, but could be a simple quality of life fix, it did not take too long to identify

Actual Behaviour

nslookup failed when attempting to query '127.0.0.1 ', notice the extra space at the end.

Confirmation Checklist

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.