openwrt / openwrt/packages

linuxptp: no init script or uci-compatible configs

Open
#26,546 2 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Makefile
Stars
4.6k
Forks
4k
Avg merge
3d 12h
Merged PRs (30d)
134

Description

I have been playing around with linuxptp and i realize there's no init scripts nor config for the daemons that are available with the linuxptp package.

So i slapped together a config file i threw into/as /etc/config/linuxptp and two init scripts (/etc/init.d/phc2sys and /etc/init.d/ptp4l), and wanted to know if there's interest in putting together a PR to get these upstreamed?

Essentially, i have set up a stratum-1 timeserver for my local network using a GPS-dongle hanging off my wrt32x, which seems to have hardware-timestamping support on its four lan ports, so i can (using Chrony) have a high-accuracy NTP service, and with that, by extension, i also set up linuxptp to further make an even more accurate/precise time-source for my network (mainly my NAS which also has hardware timestamping).

Not sure what the typical use-case is for people installing the linuxptp package, but wondering if i should create a PR to make this config and init scripts available to folks? I'm also not sure whether it's going to be allowed that i have two init scripts that refer to one config file or if that violates some kind of openwrt policy.

cc: @shenghaoyang @BKPepe for visibility (as recent PR-submitters/maintainers of the package).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with CONTRIBUTING.md and the linuxptp package, then review the proposed /etc/config/linuxptp file and the /etc/init.d/phc2sys and /etc/init.d/ptp4l entry points. Confirm the package's configuration and init-script conventions, and determine whether both scripts can share one UCI config; done means an accepted upstream configuration and init-script set.

Written by the indexing model from the issue text.

Assessment

Tech stack
linux
Domain
operating-systems
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.