openwrt / openwrt/packages

olsrd log spam with default configuration

Open
#26,464 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Makefile
Stars
4.6k
Forks
4k
Avg merge
3d 12h
Merged PRs (30d)
134

Description

olsrd/olsrd6 default configuration when the package is installed is to run on wlan network. There are two problems with this:

1- If wlan does not exist it does not end up in /var/etc/olsrd.conf and /var/etc/olsrd6.conf and thus that configuration has no networks and the daemons exits immediately then are restarted by procd, resulting in a ton of log spam.

I fixed it by adding a check in /etc/init.d/olsrd and /etc/init.d/olsrd6 in my system for the number of interfaces in the generated /var/etc configs:

...
start_service() {
olsrd_generate_config $OLSRD
[ "$INTERFACES_COUNT" -le 0 ] && return 1
...

These files are here in the routing feed:

feeds/routing/olsrd/files/olsrd4.init
feeds/routing/olsrd/files/olsrd6.init

2- Starting the daemons with a default configuration on an interface is wrong. olsrd is complex and it is OK to force the user to do some actual configuration in addition to installing the package. olsrd daemons shound be disabled by default.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with feeds/routing/olsrd/files/olsrd4.init and feeds/routing/olsrd/files/olsrd6.init, then inspect how the generated /var/etc/olsrd.conf and /var/etc/olsrd6.conf determine the interface count. Verify the daemons do not repeatedly restart when no wlan interface is configured, and review the requested default-disabled behavior for both services.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.