libtins: Don't throw exception on invalid interface
Nobody has claimed this yet.
- Dominant language
- Makefile
- Stars
- 4.6k
- Forks
- 4k
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 134
Description
Issue template (remove lines from top till here)
Environment: openwrt 23.05.5 maybe others, likely all archs
Description:
This library throws an exception when an "invalid interface" is seen, which it defines as having no ip address and no mac address. But I believe this is the case for certain interfaces, like vpn ifs.
The simple workaround is to just comment out the exception, and everything works fine.
I made a patch here:
https://github.com/someburner/openwrt-feeds/blob/master/libtins45/patches/011-no-throw-empty-iface.patch
But figured I'd make an issue first.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the linked 011-no-throw-empty-iface.patch in the libtins45 package directory and the issue's description of interfaces without IP or MAC addresses. Verify the behavior for VPN or similarly empty interfaces, then confirm that valid package builds no longer throw for these cases.
Written by the indexing model from the issue text.
Assessment
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100